New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: add named imports and exports for object-curly-newline #9876
Merged
ilyavolodin
merged 12 commits into
eslint:master
from
nicholaschuayunzhi:8501-import-export-config
Feb 10, 2018
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6463a8c
Update: add ImportDeclaration and ExportDeclaration
nicholaschuayunzhi 728ad32
Chore: add tests for import/export declaration
nicholaschuayunzhi e4017f7
Docs: update docs for object-curly-newline
nicholaschuayunzhi dcef6de
Chore: update comment in object-curly-newline
nicholaschuayunzhi 245b20e
Chore: fix JSDoc error
nicholaschuayunzhi d6e275d
Chore: add sourceType module to RuleTester option
nicholaschuayunzhi 9708cdb
Update: combine logic for finding closing brace
nicholaschuayunzhi 0020669
Chore: extract function, needsLinebreaks
nicholaschuayunzhi 0082680
Docs: revert remove of "and"
nicholaschuayunzhi 75bea25
Update: rewrite logic for node options
nicholaschuayunzhi 005032d
Docs: Correct grammar for options
nicholaschuayunzhi fd1a780
Chore: Correct grammar in JSDoc
nicholaschuayunzhi File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a JSCS rule we are now compatible with for padding new lines for import/export specifiers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't seem to be any JSCS rule regarding new lines and import/export specifiers. Only ones for spaces in the import braces.
requireSpacesInsideImportedObjectBraces
disallowSpacesInsideImportedObjectBraces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking!