New: add "multiline" option to padding-line-between-statements (#9642) #9644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aladdin-add
added
enhancement
|
Looks like both #9642 and #9491 relate to this general idea. #9491 is accepted right now. @hotforfeature Could you please take a look at both of the issues linked above and let us know if #9642 is definitely proposing something that #9491 is missing (or vice versa), or if the proposal in #9491 might be suitable for your use case? |
|
Yes, it looks like #9491 is proposing the same thing as what I proposed and added. I must have missed it when searching through the issues before I created mine. |
|
@hotforfeature No problem. Since #9491 is accepted, do you want to modify this PR to match that issue and close the other issue? Thanks! |
|
closing, since #8668 get merged. thanks for contributing! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
#9642
What changes did you make? (Give an overview)
Added an
isMultilineStatement(node)function to the rule, and implemented a new"multiline"option that uses It. I also modified the"multiline-block-like"option to use the new function.Is there anything you'd like reviewers to focus on?
I haven't added tests yet, I'm trying to wrap my head around how the test cases work. Any help or suggestions are welcome.