Fix: remove dupe error message in bin/eslint (fixes #8964)

[VictorHom]

[X ] Other, please explain: remove the dupe error message which re-adds what was previously fixed in here

[eslintbot]

LGTM

[mention-bot]

@VictorHom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @nzakas and @platinumazure to be potential reviewers.

[eslintbot]

LGTM

[not-an-aardvark]

Thanks for the PR! Sorry about the delayed response.

The fix in #8965 was reverted as a result of #9011 (it was causing some error messages to not appear at all). Has that problem been solved? It seems like if we make only this change, the problem described in #9011 (comment) will reappear.

[VictorHom]

@not-an-aardvark Can you recreate the issue? Im currently using:

(venv) ➜ eslint_sandbox node --version
v8.2.1
(venv) ➜ eslint_sandbox npm -version
5.3.0

With the latest eslint and with this change in the pr, I am not getting duplicated error messages.

Do you have a way to create case where no error message show at all?

[not-an-aardvark]

I tested this by adding a space character to the beginning of the .eslintrc.yml file in the ESLint repository, (making it invalid YAML), then running bin/eslint.js Makefile.js.

On master, the output is:

Cannot read config file: /path/to/eslint/.eslintrc.yml
Error: end of the stream or a document separator is expected at line 3, column 1:
    plugins:
    ^
YAMLException: end of the stream or a document separator is expected at line 3, column 1:
    plugins:
    ^
    at generateError (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:165:10)
    at throwError (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:171:9)
    at readDocument (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1512:5)
    at loadDocuments (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1548:5)
    at load (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1569:19)
    at Object.safeLoad (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1591:10)
    at loadYAMLConfigFile (/path/to/eslint/lib/config/config-file.js:95:21)
    at loadConfigFile (/path/to/eslint/lib/config/config-file.js:231:22)
    at loadFromDisk (/path/to/eslint/lib/config/config-file.js:530:18)
    at Object.load (/path/to/eslint/lib/config/config-file.js:592:20)

On this branch, the output is:

YAMLException: end of the stream or a document separator is expected at line 3, column 1:
    plugins:
    ^
    at generateError (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:165:10)
    at throwError (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:171:9)
    at readDocument (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1512:5)
    at loadDocuments (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1548:5)
    at load (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1569:19)
    at Object.safeLoad (/path/to/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1591:10)
    at loadYAMLConfigFile (/path/to/eslint/lib/config/config-file.js:95:21)
    at loadConfigFile (/path/to/eslint/lib/config/config-file.js:231:22)
    at loadFromDisk (/path/to/eslint/lib/config/config-file.js:530:18)
    at Object.load (/path/to/eslint/lib/config/config-file.js:592:20)

Note that the line at the top ("Cannot read config file: /path/to/eslint/.eslintrc.yml") is missing when using this branch.

[not-an-aardvark]

Temporarily requesting changes due to #9320 (comment) to ensure that this doesn't get accidentally merged before we figure out the missing error messages.

[kaicataldo]

Where do we stand with this?

[kaicataldo]

Friendly ping!