New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add error mssg in bin/eslint (fixes #9011) #9041
Conversation
@VictorHom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @nzakas and @platinumazure to be potential reviewers. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/bin/eslint.js
Outdated
@@ -271,9 +271,6 @@ describe("bin/eslint.js", () => { | |||
|
|||
assert.strictEqual(output.stdout, ""); | |||
assert.include(output.stderr, expectedSubstring); | |||
|
|||
// The message should appear exactly once in stderr | |||
assert.strictEqual(output.stderr.indexOf(expectedSubstring), output.stderr.lastIndexOf(expectedSubstring)); | |||
}); | |||
|
|||
return Promise.all([exitCodeAssertion, outputAssertion]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a regression test for #9011?
LGTM |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Thanks for contributing! |
[ X] Bug fix (template)
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
eslint: v4.3.0
node: v8.2.1
npm: 3.10.10
What changes did you make? (Give an overview)
Add back err.message to bin/eslint
It provides clearer error messaging. It undoes changes here to reduce duplicate error messaging in err.message and err.stack
Is there anything you'd like reviewers to focus on?