Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Allow eslint-disable-line to be wrapper in BlockComment #8780

Closed
wants to merge 1 commit into from

Conversation

qfox
Copy link

@qfox qfox commented Jun 22, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Allow to use eslint-disable-line in block-comment as it was in JSCS: /* jscs:ignore */.

Is there anything you'd like reviewers to focus on?

I've moved out a function for disabling line and feels like there were a bug in eslint-disable-next-line because it skipped errors for rules that reporting column: 0 (like max-len or valid-jsdoc, etc.).

Fixes #8781

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@zxqfox, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @tofumatt and @gyandeeps to be potential reviewers.

@not-an-aardvark
Copy link
Member

Thanks for the PR.

Since this is a change to core, would you mind making an issue with a proposal for it? According to our guidelines, all changes to core need to have an issue so that the proposal can be discussed independently of the implementation. (Admittedly, this proposal is relatively straightforward, but I still think it would be good to make an issue for it.)

@not-an-aardvark not-an-aardvark added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 22, 2017
@qfox
Copy link
Author

qfox commented Jun 22, 2017

Ouch, missed that. Filing... → #8781

@gyandeeps
Copy link
Member

are we still doing this? if not then we should close this.

@not-an-aardvark
Copy link
Member

not-an-aardvark commented Nov 22, 2017

#8781 was accepted, so we are doing this change.

However, the implementation of eslint-disable comments has changed significantly since this PR was created. It looks like someone is already doing a new implementation of this PR, based on #8781 (comment).

@ilyavolodin
Copy link
Member

Closing in favor of #9745

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 22, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 22, 2018
@kaicataldo kaicataldo deleted the eslint-disable-line-block branch July 31, 2020 23:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support block-comment version of eslint-disable-line
6 participants