Created no-dangle rule. #87
Conversation
|
This regex is not going to be sufficient. You should be using the token stream and looking at the token right before the closing curly brace. |
|
I agree, can you use getTokens() instead? |
|
Thanks guys! I knew there had to be a better way to do that! I've rewritten and re-pushed the commit for the rule using the new approach. |
|
Very nice. So much better. |
|
Shouldn't you be able to apply this same rule to ArrayExpressions? |
|
@michaelficarra Yes! That's a good point. |
Created the no-dangle rule, which warns when it encounters a trailing comma in an object literal. The following will raise warnings:
var foo = {
bar: "baz",
}
Fixes issue eslint#13
|
... or we could just forget about them |
|
@nzakas ? |
|
@michaelficarra Checking ArrayExpressions for trailing commas was in the commit that was merged. |
|
Ah, I see. I did not see that you updated the pull request already. Thanks for the clarification! |
| secondToLastToken = tokens[tokens.length - 2]; | ||
|
|
||
| // The last token in an object/array literal will always be a closing | ||
| // curly, so we check the second to last token for a comma. |
There was a problem hiding this comment.
always be a closing curly
or square bracket
|
This matches JSHint, so I'm happy. :) |
eslint-deprecated
bot
added
the
archived due to age
Created the
no-danglerule, which warns when it encounters a trailing comma in an object literal. The following will raise warnings:I've accomplished trailing comma detection by doing a regex match on the
ObjectExpressionnode source. I investigated inspecting theObjectExpression's properties, however they don't seem to contain any comma information. This seemed like the best possible way to get this rule, but I'd love to hear if there's a better approach.I've defaulted
no-dangleto on, because trailing commas will cause errors in IE, so it seemed like a sane default.Fixes issue #13