Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Mark object-shorthand as fixable. #6485

Merged
merged 1 commit into from Jun 21, 2016

Conversation

NickHeiner
Copy link
Contributor

The contributing instructions ask for each PR to have an issue as well. I am happy to do that, but in this case it seemed sufficiently trivial that a separate issue was not necessary.

This is a follow-up to #6418.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @scriptdaemon, @pedrottimark and @lemonmade to be potential reviewers

@pedrottimark
Copy link
Member

@NickHeiner Thank you. Your commit message is fine. Docs tag is enough.

Somewhere in docs explains, but possibly not everywhere. Can you do me a favor to paste a link to the section that was not clear to you?

If you point at the right of the heading text, and then click the anchor that appears, the anchor link appears in browser address bar.

@NickHeiner
Copy link
Contributor Author

Somewhere in docs explains, but possibly not everywhere. Can you do me a favor to paste a link to the section that was not clear to you?

I'm not sure what you're asking me.

@pedrottimark
Copy link
Member

@NickHeiner Sorry. When you mentioned the contributing instructions in #6485 (comment) did you mean feedback from the bot or something you read in the docs on the site implied you had to open an issue first. That has come up before, and so I would like to see what we can do to make the requirements clearer for Docs PRs.

@originalfoo
Copy link
Contributor

@pedrottimark The only mention I've seen in the guides about not needing separate issue for Docs PRs is a single (easily missed) bullet point here: http://eslint.org/docs/developer-guide/contributing/pull-requests#getting-started

@NickHeiner
Copy link
Contributor Author

Yes @aubergine10 that's exactly what I was going off of. But now that you link to it again, I do see that it says docs-only PRs do not need issues. 😄

@pedrottimark
Copy link
Member

Thanks guys. On the main goal, the rules index and rule doc looks good to me 👍

@nzakas
Copy link
Member

nzakas commented Jun 21, 2016

FYI: The bot will warn you if you need an issue for your PR.

Is this ready for merge?

@ilyavolodin
Copy link
Member

Yes, good to merge.

@ilyavolodin ilyavolodin merged commit c2c6cec into eslint:master Jun 21, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants