Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Keep indentation when fixing padded-blocks "never" (fixes #6454) #6456

Merged
merged 1 commit into from Jun 19, 2016

Conversation

Mardak
Copy link
Contributor

@Mardak Mardak commented Jun 17, 2016

For #6454, keep the leading spaces/tabs instead of deleting up to the nextToken. Fixes/adds tests.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @alberto, @vitorbal and @nzakas to be potential reviewers

@eslintbot
Copy link

LGTM

@ilyavolodin
Copy link
Member

@alberto Could you take a look please?

@nzakas
Copy link
Member

nzakas commented Jun 18, 2016

LGTM

@alberto
Copy link
Member

alberto commented Jun 18, 2016

LGTM. I left it out for the indent rule to fix it, but I am ok taking care of it here.

@gyandeeps
Copy link
Member

LGTM 👍
Thanks for contributing.

@gyandeeps gyandeeps merged commit 3c9ce09 into eslint:master Jun 19, 2016
@Mardak Mardak deleted the issue6454 branch June 19, 2016 11:04
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants