New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to make fix
param more clear in NodeJS API
#6367
Conversation
Thanks for the pull request, @NickHeiner! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
By analyzing the blame information on this pull request, we identified @nzakas, @gyandeeps and @ilyavolodin to be potential reviewers |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
LGTM |
I'd love to see a quick sentence in |
LGTM |
Yep, that makes sense to me. I've signed the CLA, but it is not yet showing up in the PR checks. Does that take some time to propagate? |
Regarding jQuery CLA, I know that it's very finicky about your name and e-mail address (which you specified on signing the CLA). The e-mail address has to exactly match the EDIT: |
If my memory is correct, jQuery CLA does not accept |
Doc changes LGTM, but I would be grateful if @nzakas or @pedrottimark could take a look. |
@NickHeiner Regarding jQuery CLA: Actually, seems jQuery CLA just doesn't accept e-mail addresses with that domain name, in case they need to contact you or whatnot. My apologies, but you're going to need to configure Git, GitHub, and the CLA with a different e-mail. Sorry for missing that earlier. |
LGTM |
Updating the NodeJS API docs to avoid surprising developers using the `fix` param.
LGTM |
Ok, I've fixed the email / CLA issue. Thanks for your help on that. |
Thanks @NickHeiner LGTM. |
See #6366.