Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add metadata to existing rules - Batch 7 (refs #5417) #5969

Merged
merged 1 commit into from Apr 26, 2016

Conversation

vitorbal
Copy link
Member

Chore: Add metadata to existing rules - Batch 7 of 7 (refs #5417)
Last batch! 馃帀

Chore: Add metadata to existing rules - Batch 7 of 7 (refs eslint#5417)
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @alberto, @gyandeeps and @nzakas to be potential reviewers

@pedrottimark
Copy link
Member

Verified the meta.docs and meta.fixable properties compared to the README.md file.

@vitorbal Good work! You saved the best for last, escaping the double quote marks in the description of yoda rule. You have earned a free one-year membership in the mention-bot club 馃槣

@nzakas
Copy link
Member

nzakas commented Apr 26, 2016

@vitorbal thanks so much for this. You are our hero!
xzqhtfc

@nzakas nzakas merged commit 42d1ecc into eslint:master Apr 26, 2016
@vitorbal
Copy link
Member Author

@pedrottimark haha, true :) I did notice a sudden increase in my github notifications... 馃檴
@nzakas thank you so much! it's a pleasure to contribute to such a great tool :)

@vitorbal vitorbal deleted the metadata7 branch April 26, 2016 21:28
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants