Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Organize meta and describe visitor in Working with Rules #5967

Merged
merged 1 commit into from May 3, 2016

Conversation

pedrottimark
Copy link
Member

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @ilyavolodin, @evangoer and @nzakas to be potential reviewers

ReturnStatement: function(node) {
// at a ReturnStatement node while going down
},
"FunctionExpression:exit":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something? This property needs a value (there is no fallthrough of object key/value pairs).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@platinumazure You will smile. I woke up this morning thinking how I left out the case keywords at the fallthrough for function expressions, and then, oh noooo!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay, we all have days like that. Good work on these docs!

@eslintbot
Copy link

LGTM

@jfmengels
Copy link
Contributor

LGTM :)

@nzakas
Copy link
Member

nzakas commented Apr 26, 2016

Waiting on feedback from @mysticatea

@eslintbot
Copy link

LGTM

@pedrottimark
Copy link
Member Author

Motivated by discussion in chat, added under Applying Fixes an Important note about meta.fixable property with a link to Rule Basics.

@nzakas
Copy link
Member

nzakas commented May 3, 2016

Lgtm. Would rather merge in now and update later if we find problems.

@nzakas nzakas merged commit a2cc54e into master May 3, 2016
@pedrottimark pedrottimark deleted the docs-meta-visitor branch May 3, 2016 17:37
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants