New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Organize meta and describe visitor in Working with Rules #5967
Conversation
LGTM |
By analyzing the blame information on this pull request, we identified @ilyavolodin, @evangoer and @nzakas to be potential reviewers |
ReturnStatement: function(node) { | ||
// at a ReturnStatement node while going down | ||
}, | ||
"FunctionExpression:exit": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I missing something? This property needs a value (there is no fallthrough of object key/value pairs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@platinumazure You will smile. I woke up this morning thinking how I left out the case
keywords at the fallthrough for function expressions, and then, oh noooo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay, we all have days like that. Good work on these docs!
b731dcc
to
ae72b42
Compare
LGTM |
LGTM :) |
Waiting on feedback from @mysticatea |
ae72b42
to
95af0ea
Compare
LGTM |
Motivated by discussion in chat, added under Applying Fixes an Important note about |
Lgtm. Would rather merge in now and update later if we find problems. |
array-callback-return
in the second source file example