Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add metadata to existing rules - Batch 6 (refs #5417) #5966

Merged
merged 1 commit into from Apr 26, 2016

Conversation

vitorbal
Copy link
Member

Chore: Add metadata to existing rules - Batch 6 of 7 (refs #5417)

Chore: Add metadata to existing rules - Batch 6 of 7 (refs eslint#5417)
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @alberto, @mysticatea and @IanVS to be potential reviewers

@pedrottimark
Copy link
Member

Verified the meta.docs and meta.fixable properties compared to the README.md file.

recommended: false
},

schema: []
Copy link

@qfox qfox Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, if I'm late, but diff should looks much better with fixes like:

exports.meta = {...};
exports.create = function(context) { ...

instead of assigning new object:
module.exports = { meta: ..., create: ... };.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah a bit late. We decided on this format a while back and have already converted a lot of rules to this format. So, we need to continue along this path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more batch left before the pain is done :)

@pedrottimark
Copy link
Member

@zxqfox Yeah, no fun right now, but as a guess, assigning object literal to module.exports was considered important to emphasize the difference between new rule format and old asymmetrical rule format which assigned module.exports to the function and then the schema to a property. Compare:

@nzakas nzakas merged commit d24516a into eslint:master Apr 26, 2016
@vitorbal vitorbal deleted the metadata6 branch April 26, 2016 08:49
@qfox
Copy link

qfox commented Apr 26, 2016

@pedrottimark I understand that and strongly agree. Just afraid about git history for these files. We could do it saving indent. Nvm already ;-)

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants