New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add metadata to existing rules - Batch 6 (refs #5417) #5966
Conversation
Chore: Add metadata to existing rules - Batch 6 of 7 (refs eslint#5417)
LGTM |
By analyzing the blame information on this pull request, we identified @alberto, @mysticatea and @IanVS to be potential reviewers |
Verified the meta.docs and meta.fixable properties compared to the README.md file. |
recommended: false | ||
}, | ||
|
||
schema: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, if I'm late, but diff should looks much better with fixes like:
exports.meta = {...};
exports.create = function(context) { ...
instead of assigning new object:
module.exports = { meta: ..., create: ... };
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah a bit late. We decided on this format a while back and have already converted a lot of rules to this format. So, we need to continue along this path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more batch left before the pain is done :)
@zxqfox Yeah, no fun right now, but as a guess, assigning object literal to |
@pedrottimark I understand that and strongly agree. Just afraid about git history for these files. We could do it saving indent. Nvm already ;-) |
Chore: Add metadata to existing rules - Batch 6 of 7 (refs #5417)