New: Rule - 'lines-between-class-methods' (fixes #5949)

[LinusU]

This is the first time I'm writing a rule for eslint so please take an extra hard look so that I don't screw anything up :)

Things to do:

• Bikeshed name
• Handle comments

Edit:
Handled comments, changed the name and squashed everything into one commit.

Should be ready for review now 🙌

If anyone is interested in the separate commits, here they are: https://github.com/LinusU/eslint/tree/class-padding-history

[eslintbot]

LGTM

[mention-bot]

By analyzing the blame information on this pull request, we identified @nzakas, @scriptdaemon and @alberto to be potential reviewers

[jquerybot]

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

---

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

[nzakas]

Marking as "do not merge" because the issue isn't accepted yet

[LinusU]

@nzakas The issue has been updated to "Accepted" now. Is there anything that I should do at this point?

[ilyavolodin]

Issue is now accepted. Removing "do not merge". @LinusU no, you don't need to do anything yet. We'll code review this and leave you feedback if anything needs to be updated. (It's going to be a little while before we get to this, due to the fact that we are focused on fixing issues with the last release at the moment).

[LinusU]

No stress, thank you for the fast response :)

[ilyavolodin]

LGTM. You might want to make this rule fixable. Should be pretty easy, since it's just whitespace fixing. Although you might run into trouble with comments.

[nzakas]

There's an open discussion about whether this should be folded into a more general rule about lines after block statements: #3092

[eslintbot]

LGTM

[LinusU]

Rebased on master, any updates on this?

[vitorbal]

Hi @LinusU, could you make sure the rule adheres to the new rule format that was introduced since you first submitted the PR? More information about the new format can be found here:
http://eslint.org/docs/developer-guide/working-with-rules

Also, we recently switched the no-var rule on for our codebase so it looks like you got a couple of linting errors because of that as well.

[vitorbal]

@LinusU Just to make sure it's still clear: as @nzakas mentioned, until the discussions in #3092 finish, we can't merge this yet.
Thank you for your understanding!

[kaicataldo]

We've actually consolidated the original issue and a few others into one issue (all dealing with padding blocks with newlines) here: #7356

Really appreciate all the work you did on this rule - we're still trying to decide exactly how we want to proceed. Feel free to join in on the discussion.

[kaicataldo]

On a side note - it doesn't look like we're going to be going with a separate rule implementation (though nothing is set in stone yet) specifically for lines between class methods, so chances are we won't be able to merge the PR in its current state.

[kaicataldo]

Ah, looks like there's another PR for this same issue: #6445

[alberto]

Closing this as we decided to go with a different rule proposal: #7356 (comment)

We appreciate your work here @LinusU and we hope you can keep contributing to eslint. Things don't usually take this long to get sorted out.

[kaicataldo]

Thanks @LinusU for your contribution!