New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add except-object
option to arrow-body-style
rules.
#5934
Add except-object
option to arrow-body-style
rules.
#5934
Conversation
Thanks for the pull request, @duncanbeevers! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
7e7cf00
to
f73e826
Compare
Adding "do not merge" because the issue isn't accepted yet. |
…t#5936) Blockless arrow functions are awesome, but when returning an object literal it's necessary to enclose the return value in parentheses. This rule extension enforces blockless arrow functions excluding cases where the arrow function returns an object literal.
f73e826
to
58cd1e0
Compare
Rebased against fc78e78 |
The Travis CI failure against node v0.12 appears to be spurious. I pushed an identical branch to trigger another build and got all green. |
I restarted the Travis build for Node.js 0.12. |
@duncanbeevers Do you intend to keep working on this? |
Blockless arrow functions are awesome, but when returning an object literal it's necessary to enclose the return value in parentheses. This rule extension enforces blockless arrow functions excluding cases where the arrow function returns an object literal.