Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add except-object option to arrow-body-style rules. #5934

Conversation

duncanbeevers
Copy link
Contributor

Blockless arrow functions are awesome, but when returning an object literal it's necessary to enclose the return value in parentheses. This rule extension enforces blockless arrow functions excluding cases where the arrow function returns an object literal.

@eslintbot
Copy link

Thanks for the pull request, @duncanbeevers! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vitorbal, @alberto and @nzakas to be potential reviewers

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@duncanbeevers duncanbeevers force-pushed the arrow-body-style-except-object branch 2 times, most recently from 7e7cf00 to f73e826 Compare April 22, 2016 20:37
@nzakas nzakas added the do not merge This pull request should not be merged yet label Apr 23, 2016
@nzakas
Copy link
Member

nzakas commented Apr 23, 2016

Adding "do not merge" because the issue isn't accepted yet.

…t#5936)

Blockless arrow functions are awesome, but when returning an object literal it's necessary to enclose the return value in parentheses. This rule extension enforces blockless arrow functions excluding cases where the arrow function returns an object literal.
@duncanbeevers
Copy link
Contributor Author

Rebased against fc78e78

@duncanbeevers
Copy link
Contributor Author

The Travis CI failure against node v0.12 appears to be spurious. I pushed an identical branch to trigger another build and got all green.

@btmills
Copy link
Member

btmills commented Apr 26, 2016

I restarted the Travis build for Node.js 0.12.

@alberto
Copy link
Member

alberto commented Jun 8, 2016

@duncanbeevers Do you intend to keep working on this?

@duncanbeevers
Copy link
Contributor Author

@alberto Replied on #5936

@BYK BYK closed this Jun 9, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion do not merge This pull request should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants