Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support custom severity when reporting unused disable directives #17212
feat: Support custom severity when reporting unused disable directives #17212
Changes from 46 commits
8518c04
9d70807
3e3d482
3cb8616
4b8ce60
d185024
6e4cb25
a1295c0
6f2bd3c
7dd444b
82ebdd3
964f270
56aa528
7294056
c774f31
9f2dc93
abf2ebc
2106b44
9818046
c6a23bf
321de72
9743273
de86902
28341c4
b4ab419
f0e89d4
4ca4f69
e7dba74
13c456d
fa35e5f
8951732
186408d
7c88af0
9fd8d6d
3c88633
b493bbb
cadb6d5
67cfb8f
7f8d0a8
ae363bf
30e3f30
eb25551
68a9b83
dd9861c
ff813a1
194c649
7fe6ef0
62ab43c
e43952e
9874ae5
bec28fb
8c9f33f
43ad9fd
462bc31
54cc4a3
691b142
4b3d2d8
f9b60f0
ba288e6
cd36dd7
ddf9aa2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't strictly a severity schema as it supports boolean values, too. So maybe we rename it to
disableDirectiveSeveritySchema
for clarity?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.