Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add suggestion for no-return-await #16637

Merged
merged 14 commits into from Dec 16, 2022
Merged

feat: add suggestion for no-return-await #16637

merged 14 commits into from Dec 16, 2022

Commits on Dec 10, 2022

  1. refactor: extract error list into a function 

    Suggestions will be different for different errors, so a constant object won't work anymore
    @dbartholomae
    dbartholomae committed Dec 10, 2022
    Copy the full SHA
    1cb6e4a View commit details
    Browse the repository at this point in the history

  2. feat: suggest removing await in no-return-await

    @dbartholomae
    dbartholomae committed Dec 10, 2022
    Copy the full SHA
    60fe835 View commit details
    Browse the repository at this point in the history

  3. Fix suggestion message 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @dbartholomae @mdjermanovic
    dbartholomae and mdjermanovic committed Dec 10, 2022
    Copy the full SHA
    04675b3 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. refactor: remove unused data

    @dbartholomae
    dbartholomae committed Dec 11, 2022
    Copy the full SHA
    4a14630 View commit details
    Browse the repository at this point in the history

  2. fix: only trim after await if there is a space

    @dbartholomae
    dbartholomae committed Dec 11, 2022
    Copy the full SHA
    1d20ef1 View commit details
    Browse the repository at this point in the history

  3. refactor: allow expecting no suggestion

    @dbartholomae
    dbartholomae committed Dec 11, 2022
    Copy the full SHA
    5cfaa84 View commit details
    Browse the repository at this point in the history

  4. refactor: move code for fixing into fix function

    @dbartholomae
    dbartholomae committed Dec 11, 2022
    Copy the full SHA
    80bb8d7 View commit details
    Browse the repository at this point in the history

  5. fix: do not suggest a fix if await and awaited expression are not on … 

    …th same line
    @dbartholomae
    dbartholomae committed Dec 11, 2022
    Copy the full SHA
    ee4087d View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Simplify suggestion message 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @dbartholomae @mdjermanovic
    dbartholomae and mdjermanovic committed Dec 14, 2022
    Copy the full SHA
    abd1d48 View commit details
    Browse the repository at this point in the history

  2. Simplify single-character access 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @dbartholomae @mdjermanovic
    dbartholomae and mdjermanovic committed Dec 14, 2022
    Copy the full SHA
    2a257d6 View commit details
    Browse the repository at this point in the history

  3. Simplify removing a range 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @dbartholomae @mdjermanovic
    dbartholomae and mdjermanovic committed Dec 14, 2022
    Copy the full SHA
    ab271b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. feat: suggest removing await when expression starts with (

    @dbartholomae
    dbartholomae committed Dec 15, 2022
    Copy the full SHA
    2331840 View commit details
    Browse the repository at this point in the history

  2. refactor: use awaitToken to determine await range

    @dbartholomae
    dbartholomae committed Dec 15, 2022
    Copy the full SHA
    725423a View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. fix: use more performant way to identify tokens

    @dbartholomae
    dbartholomae committed Dec 16, 2022
    Copy the full SHA
    6160c18 View commit details
    Browse the repository at this point in the history