Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix Header UI inconsistency #16464

Merged
merged 5 commits into from Nov 17, 2022
Merged

docs: fix Header UI inconsistency #16464

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce43077
fix: Header UI inconsistency
Tanujkanti4441 Oct 27, 2022
0633b4f
fix: unexpected empty line
Tanujkanti4441 Nov 1, 2022
ab29b3b
fix: additional class
Tanujkanti4441 Nov 1, 2022
677ec36
fix: design break on mobile size
Tanujkanti4441 Nov 6, 2022
14f1ab0
fix: UI of other pages on docs
Tanujkanti4441 Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/src/assets/scss/docs-header.scss
View file
Open in desktop
Expand Up @@ -12,6 +12,8 @@
padding-bottom: 0;
padding-block-start: 0;
padding-block-end: 0;
max-width: 1700px;
margin: auto;

@media all and (min-width: 1024px) {
justify-content: space-between;
Expand Down
10 changes: 6 additions & 4 deletions docs/src/assets/scss/docs.scss
View file
Open in desktop
Expand Up @@ -4,10 +4,10 @@ html {
scroll-behavior: smooth;
}

.docs {
max-width: 1700px;
margin: 0 auto;
}
// .docs {
// max-width: 1700px;
// margin: 0 auto;
// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just remove it? And don't forget to remove docs class name in html file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


.docs-aside__content {
flex: 1;
Expand All @@ -18,6 +18,8 @@ html {
flex: 1;
display: flex;
flex-direction: column;
max-width: 1700px;
margin: auto;

@media all and (min-width: 1024px) {
display: grid;
Expand Down