Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore messages without a ruleId in getRulesMetaForResults #16409

Merged
merged 3 commits into from Oct 19, 2022
Merged

fix: ignore messages without a ruleId in getRulesMetaForResults #16409

merged 3 commits into from Oct 19, 2022

Commits on Oct 11, 2022

  1. fix: ignore messages without a ruleId in getRulesMetaForResults 

    * `FlatESLint.prototype.getRulesMetaForResults` will now ignore messages without a `ruleId` instead of crashing with a `TypeError`.
* Unit tests for `getRulesMetaForResults` added for both `FlatESLint` and `ESLint`.
* The unit test "should return one rule meta when there is a suppressed linting error" was ported to `FlatESLint`. This was originally introduced for `ESLint` in #15459.

Fixes #16402
    @fasttime
    fasttime committed Oct 11, 2022
    Copy the full SHA
    72cab02 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Update unit tests as suggested

    @fasttime
    fasttime committed Oct 14, 2022
    Copy the full SHA
    61768c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Explicitly ignore a file path in a unit test for `getRulesMetaForResu… 

    …lts`
    @fasttime
    fasttime committed Oct 16, 2022
    Copy the full SHA
    1d6060c View commit details
    Browse the repository at this point in the history