chore: tweak the pull request template #16401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the checkbox UI of the pull request template consistent. By changing `[ ]` to `- [ ]`, it will look like a list of check items on Web browser. So `[x]` is `[x]`, but `- [x]` is ☑️. I noticed this when I made my first contribution to this repository.
eslint-github-bot
bot
added
triage
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kecrily
reviewed
Oct 9, 2022
| @@ -15,14 +15,14 @@ | |||
| explained in https://github.com/eslint/eslint/pull/12848#issuecomment-580302888 | |||
|
Closing, because it is intentionally not a checkbox list. |
|
My doc confirmation was not enough. Thank you for the explanation! |
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
This PR makes the checkbox UI of the pull request template consistent. By changing
[ ]to- [ ], it will look like a list of check items on Web browser. So[x]is[x], but- [x]is ☑️.Is there anything you'd like reviewers to focus on?
I noticed this when I made my first contribution #16398 to this repository.