Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: id-length counts graphemes instead of code units #16321

Merged
merged 11 commits into from Sep 27, 2022
Merged

feat: id-length counts graphemes instead of code units #16321

merged 11 commits into from Sep 27, 2022

Commits on Sep 17, 2022

  1. fix: counts graphemes instead of code units

    @sosukesuzuki
    sosukesuzuki committed Sep 17, 2022
    Copy the full SHA
    81deaf6 View commit details
    Browse the repository at this point in the history

  2. test: add more tests

    @sosukesuzuki
    sosukesuzuki committed Sep 17, 2022
    Copy the full SHA
    39928ab View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2022

  1. test: add more valid tests

    @sosukesuzuki
    sosukesuzuki committed Sep 18, 2022
    Copy the full SHA
    51508d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. docs: mention about grapehemes

    @sosukesuzuki
    sosukesuzuki committed Sep 23, 2022
    Copy the full SHA
    04802f9 View commit details
    Browse the repository at this point in the history

  2. fix: first check if string is ASCII

    @sosukesuzuki
    sosukesuzuki committed Sep 23, 2022
    Copy the full SHA
    a6beb2e View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. fix: use regex

    @sosukesuzuki
    sosukesuzuki committed Sep 24, 2022
    Copy the full SHA
    61d28d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Update docs/src/rules/id-length.md 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @sosukesuzuki @mdjermanovic
    sosukesuzuki and mdjermanovic committed Sep 27, 2022
    Copy the full SHA
    9249132 View commit details
    Browse the repository at this point in the history

  2. fix: add max: 1 to valid tests

    @sosukesuzuki
    sosukesuzuki committed Sep 27, 2022
    Copy the full SHA
    cb84c8c View commit details
    Browse the repository at this point in the history

  3. fix: add tests for Variation Selectors

    @sosukesuzuki
    sosukesuzuki committed Sep 27, 2022
    Copy the full SHA
    bc16453 View commit details
    Browse the repository at this point in the history

  4. Update tests/lib/rules/id-length.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @sosukesuzuki @mdjermanovic
    sosukesuzuki and mdjermanovic committed Sep 27, 2022
    Copy the full SHA
    cd906c0 View commit details
    Browse the repository at this point in the history

  5. Update tests/lib/rules/id-length.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @sosukesuzuki @mdjermanovic
    sosukesuzuki and mdjermanovic committed Sep 27, 2022
    Copy the full SHA
    edab15b View commit details
    Browse the repository at this point in the history