Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: note false positive Object.getOwnPropertyNames in prefer-reflect #16317

Merged
merged 6 commits into from Sep 19, 2022
Merged

docs: note false positive Object.getOwnPropertyNames in prefer-reflect #16317

merged 6 commits into from Sep 19, 2022

Commits on Sep 16, 2022

  1. docs: Add note to disclose inappropriate behavior 

    Due to eslint#16305 (comment) the falsely suggestion should be disclose to users to avoid further confusion

See eslint#16305
    @AnnAngela
    AnnAngela committed Sep 16, 2022
    Copy the full SHA
    c569d87 View commit details
    Browse the repository at this point in the history

  2. docs(prefer-reflect): Remove the section about getOwnPropertyNames 

    Make the document clean
    @AnnAngela
    AnnAngela committed Sep 16, 2022
    Copy the full SHA
    4c7c615 View commit details
    Browse the repository at this point in the history

  3. docs: Apply suggestions from code review 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @AnnAngela @mdjermanovic
    AnnAngela and mdjermanovic committed Sep 16, 2022
    Copy the full SHA
    019fe71 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. docs: Mark the value as string 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @AnnAngela @mdjermanovic
    AnnAngela and mdjermanovic committed Sep 19, 2022
    Copy the full SHA
    016eab8 View commit details
    Browse the repository at this point in the history

  2. docs: remove duplicated consecutive blank line 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @AnnAngela @mdjermanovic
    AnnAngela and mdjermanovic committed Sep 19, 2022
    Copy the full SHA
    e94a07a View commit details
    Browse the repository at this point in the history

  3. Update docs/src/rules/prefer-reflect.md

    @mdjermanovic
    mdjermanovic committed Sep 19, 2022
    Copy the full SHA
    e2dead9 View commit details
    Browse the repository at this point in the history