docs: remove duplicate style properties #16226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
triage
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
snitin315
added
documentation
nzakas
reviewed
Aug 25, 2022
| @@ -112,7 +111,6 @@ | |||
| } | |||
|
|
|||
| .search .search-results__item__title { | |||
| font-size: var(--step-0); | |||
There was a problem hiding this comment.
This is intentionally duplicate. The first is used when the browser support variables and the second is used when the browser does not support variables.
There was a problem hiding this comment.
Added intentional properties and removed only duplicate properties & fixed typos.
nzakas
requested changes
Oct 12, 2022
| font-size: .875rem; | ||
| font-size: var(--step-0); |
There was a problem hiding this comment.
Can we keep the original order here, with the variable version coming first?
|
|
||
| :root { |
|
@amareshsm are you going to get back to this PR? If not, we can close it. |
|
Closing in favor of #16466 |
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
In the documentation website removed duplicate style properties.
What changes did you make? (Give an overview)
In the documentation website removed duplicate style properties.