Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rule logical-assignment-operators #16102

Merged
merged 37 commits into from Sep 16, 2022
Merged

feat: add rule logical-assignment-operators #16102

merged 37 commits into from Sep 16, 2022

Commits on Jul 5, 2022

  1. feat: add rule logical-assignment-operators 

    Fixes eslint#13689
    @DMartens
    DMartens committed Jul 5, 2022
    Copy the full SHA
    e7cb5b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. docs: update rule documentation 

    - State the concept of the rule clearer
- Increase the heading level for options
    @DMartens
    DMartens committed Jul 11, 2022
    Copy the full SHA
    e320bfd View commit details
    Browse the repository at this point in the history

  2. chore: unify ast-utils import

    @DMartens
    DMartens committed Jul 11, 2022
    Copy the full SHA
    e3e4672 View commit details
    Browse the repository at this point in the history

  3. fix: only check for void 0 in undefined checks

    @DMartens
    DMartens committed Jul 11, 2022
    Copy the full SHA
    f667a30 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. fix: always fix for the logical pattern

    @DMartens
    DMartens committed Jul 12, 2022
    Copy the full SHA
    b0b978a View commit details
    Browse the repository at this point in the history

  2. feat: support yoda conditions in if conditions

    @DMartens
    DMartens committed Jul 12, 2022
    Copy the full SHA
    21cc419 View commit details
    Browse the repository at this point in the history

  3. fix: remove parenthesis around assignment target if necessary

    @DMartens
    DMartens committed Jul 12, 2022
    Copy the full SHA
    8a1da4b View commit details
    Browse the repository at this point in the history

  4. fix: parenthesize logical pattern if needed

    @DMartens
    DMartens committed Jul 12, 2022
    Copy the full SHA
    9bd6e23 View commit details
    Browse the repository at this point in the history

  5. fix: add semicolon for if patterns with a body if needed

    @DMartens
    DMartens committed Jul 12, 2022
    Copy the full SHA
    a55ae4c View commit details
    Browse the repository at this point in the history

  6. fix: remove file extension from import 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @DMartens @mdjermanovic
    DMartens and mdjermanovic committed Jul 12, 2022
    Copy the full SHA
    9a4b7f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. fix: check strictness of global scope instead of current scope to avo… 

    …id checking for with
    @DMartens
    DMartens committed Jul 13, 2022
    Copy the full SHA
    a548dd4 View commit details
    Browse the repository at this point in the history

  2. fix: check for mixed ?? and ||/&& operators in the fix for never

    @DMartens
    DMartens committed Jul 13, 2022
    Copy the full SHA
    613c2d3 View commit details
    Browse the repository at this point in the history

  3. fix: check previous token for continuation problems in the if fix

    @DMartens
    DMartens committed Jul 13, 2022
    Copy the full SHA
    ec1e1a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2022

  1. feat: support else if (and fix suggest cases for if)

    @DMartens
    DMartens committed Jul 30, 2022
    Copy the full SHA
    f964605 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. fix: do not remove else keyword for else if

    @DMartens
    DMartens committed Aug 8, 2022
    Copy the full SHA
    ef42c44 View commit details
    Browse the repository at this point in the history

  2. fix: if cases also suggest based on potential getter

    @DMartens
    DMartens committed Aug 8, 2022
    Copy the full SHA
    9d8dfc7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. fix: also fix if only a single property is accessed for the if pattern

    @DMartens
    DMartens committed Aug 11, 2022
    Copy the full SHA
    9191a66 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. fix: do not fix logical patterns with a deeper access

    @DMartens
    DMartens committed Aug 31, 2022
    Copy the full SHA
    0214ef8 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. fix: check whether Boolean references a global

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    adc1689 View commit details
    Browse the repository at this point in the history

  2. fix: allow test conditions to access the same static property (a.b <=… 

    …> a['b'])
    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    76ac24c View commit details
    Browse the repository at this point in the history

  3. fix: use the whole assignment operator with equals in the message and… 

    … add operator for 'if' messages
    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    784fefe View commit details
    Browse the repository at this point in the history

  4. docs: remove edit_link

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    fa5c0cc View commit details
    Browse the repository at this point in the history

  5. docs: remove description from docs as it is autogenerated from rule.m… 

    …eta.docs.description
    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    e159e7a View commit details
    Browse the repository at this point in the history

  6. docs: move introductory text before rule details

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    ef1a3f8 View commit details
    Browse the repository at this point in the history

  7. docs: add missing 'logical' to rule description

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    c211235 View commit details
    Browse the repository at this point in the history

  8. docs: fix formatting for options

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    aad522c View commit details
    Browse the repository at this point in the history

  9. docs: include all logical operators for option 'never'

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    863df8e View commit details
    Browse the repository at this point in the history

  10. docs: add examples for option 'always'

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    88c5360 View commit details
    Browse the repository at this point in the history

  11. docs: add examples of for the 'enforceForIfStatements' option and swa… 

    …p correct with incorrect sections
    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    a99eb62 View commit details
    Browse the repository at this point in the history

  12. fix: disallow optional chaining for the logical pattern

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    aa69bbf View commit details
    Browse the repository at this point in the history

  13. fix: fixer does not delete parenthesis around the right operand in th… 

    …e assignment pattern
    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    7f2c77f View commit details
    Browse the repository at this point in the history

  14. fix: remove multiple parenthesis around the right operand in the logi… 

    …cal pattern
    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    6e00a16 View commit details
    Browse the repository at this point in the history

  15. test: add data property for suggestions

    @DMartens
    DMartens committed Sep 6, 2022
    Copy the full SHA
    bf51265 View commit details
    Browse the repository at this point in the history

  16. docs: add missing comma in description 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @DMartens @mdjermanovic
    DMartens and mdjermanovic committed Sep 6, 2022
    Copy the full SHA
    5eb5c6b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. test: clean up unnecessary data, add missing data and pass missing op… 

    …tions for test case
    @DMartens
    DMartens committed Sep 7, 2022
    Copy the full SHA
    839145f View commit details
    Browse the repository at this point in the history

  2. fix: do not allow property accesses in a computed property when check… 

    …ing for a single property access
    @DMartens
    DMartens committed Sep 7, 2022
    Copy the full SHA
    fde5e0f View commit details
    Browse the repository at this point in the history

  3. test: add test cases for private identifiers

    @DMartens
    DMartens committed Sep 7, 2022
    Copy the full SHA
    180155d View commit details
    Browse the repository at this point in the history