New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no-warning-comments rule escapes special RegEx characters in terms #16090
Merged
mdjermanovic
merged 7 commits into
eslint:main
from
lachlanhunt:no-warning-comments-matching
Jul 9, 2022
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b3de940
fix: no-warning-comments rule escapes special RegEx characters in terms
lachlanhunt b5e779a
Fix unit test and explanatory comment
lachlanhunt 2a2569a
Fix comment about $ matching
lachlanhunt e66b7aa
Undo accidental formatting.
lachlanhunt 7b2f71e
Only include \W when the term starts or ends with a non-word character
lachlanhunt 8d05998
Performance improvements
lachlanhunt 6315060
Simplify regexes
lachlanhunt File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be the same performance issues with terms that end with non-word characters, like:
This takes a lot more time (10-20x) with the new version.
I believe the complexity in the process of generating regular expressions is pretty much the same as it was, but the generated regular expressions are more complex.
For example, instead of a simpler
/^\s*foo!/iu
, this will generate/^\s*foo!(?:\b|\W|$)/iu
, which apparently has a much worse performance (I'm not sure why).I'd suggest that we just remove the useless (and buggy)
+ eitherOrWordBoundary + term + wordBoundary
part.