Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update internal lint dependencies #16088

Merged
merged 1 commit into from Jul 4, 2022
Merged

chore: update internal lint dependencies #16088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Expand Up @@ -78,6 +78,8 @@ module.exports = {
"plugin:eslint-plugin/rules-recommended"
],
rules: {
"eslint-plugin/no-missing-message-ids": "error",
"eslint-plugin/no-unused-message-ids": "error",
"eslint-plugin/prefer-message-ids": "error",
"eslint-plugin/prefer-placeholders": "error",
"eslint-plugin/prefer-replace-text": "error",
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Expand Up @@ -47,19 +47,19 @@ Prerequisites: [Node.js](https://nodejs.org/) (`^12.22.0`, `^14.17.0`, or `>=16.

You can install ESLint using npm:

```sh
```shell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any benefit from using shell instead of sh here?

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same thing but I switched this to shell for consistency with all other 90 usages in the codebase.

npm install eslint --save-dev
```

You should then set up a configuration file:

```sh
```shell
npm init @eslint/config
```

After that, you can run ESLint on any file or directory like this:

```sh
```shell
./node_modules/.bin/eslint yourfile.js
```

Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Expand Up @@ -102,9 +102,9 @@
"eslint": "file:.",
"eslint-config-eslint": "file:packages/eslint-config-eslint",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-eslint-plugin": "^4.2.0",
"eslint-plugin-eslint-plugin": "^4.4.0",
"eslint-plugin-internal-rules": "file:tools/internal-rules",
"eslint-plugin-jsdoc": "^37.0.0",
"eslint-plugin-jsdoc": "^38.1.6",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-unicorn": "^42.0.0",
"eslint-release": "^3.2.0",
Expand All @@ -123,8 +123,8 @@
"karma-webpack": "^5.0.0",
"lint-staged": "^11.0.0",
"load-perf": "^0.2.0",
"markdownlint": "^0.24.0",
"markdownlint-cli": "^0.30.0",
"markdownlint": "^0.25.1",
"markdownlint-cli": "^0.31.1",
"marked": "^4.0.8",
"memfs": "^3.0.1",
"metascraper": "^5.25.7",
Expand Down
8 changes: 6 additions & 2 deletions packages/eslint-config-eslint/README.md
View file
Open in desktop
Expand Up @@ -10,11 +10,15 @@ Contains the ESLint configuration used for projects maintained by the ESLint tea

You can install ESLint using npm:

npm install eslint --save-dev
```shell
npm install eslint --save-dev
```

Then install this configuration:

npm install eslint-config-eslint --save-dev
```shell
npm install eslint-config-eslint --save-dev
```

## Usage

Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-eslint/package.json
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
"bugs": "https://github.com/eslint/eslint/issues/",
"peerDependencies": {
"eslint-plugin-eslint-comments": ">=3.2.0",
"eslint-plugin-jsdoc": ">=36.0.6",
"eslint-plugin-jsdoc": ">=38.1.6",
"eslint-plugin-node": ">=11.1.0",
"eslint-plugin-unicorn": ">=42.0.0"
},
Expand Down