Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix off-by-one min-width: 1023px media queries #15974

Merged
merged 1 commit into from Aug 26, 2022
Merged

chore: fix off-by-one min-width: 1023px media queries #15974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/src/assets/scss/components/docs-index.scss
View file
Open in desktop
Expand Up @@ -76,15 +76,15 @@
&[data-open="false"] {
display: none;

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: block;
}
}

&[data-open="true"] {
display: block;

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: block;
}
}
Expand All @@ -109,7 +109,7 @@
background-color: var(--secondary-button-hover-color);
}

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: none;
}

Expand Down
10 changes: 5 additions & 5 deletions docs/src/assets/scss/components/docs-navigation.scss
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
margin-block-end: 2rem;


@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
font-size: var(--step-0);
margin-top: 0;
margin-block-start: 0;
Expand Down Expand Up @@ -52,7 +52,7 @@


.docs-nav-panel {
@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: flex;
flex-direction: row;
justify-content: center;
Expand All @@ -63,7 +63,7 @@
}

&[data-open="true"] {
@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: flex;
flex-direction: row;
justify-content: center;
Expand All @@ -72,7 +72,7 @@
}

.docs-nav-panel .mobile-only {
@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: none;
}
}
Expand Down Expand Up @@ -130,7 +130,7 @@



@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
.docs-site-nav {
flex-direction: row;
grid-column: auto;
Expand Down
6 changes: 3 additions & 3 deletions docs/src/assets/scss/components/index.scss
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@
background-color: var(--secondary-button-hover-color);
}

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: none;
}

Expand Down Expand Up @@ -95,15 +95,15 @@
&[data-open="false"] {
display: none;

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: block;
}
}

&[data-open="true"] {
display: block;

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: block;
}
}
Expand Down
2 changes: 1 addition & 1 deletion docs/src/assets/scss/components/search.scss
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@
max-height: 400px;
overflow-y: auto;

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
box-shadow: var(--shadow-lg);
position: absolute;
top: calc(100% + .25rem);
Expand Down
8 changes: 4 additions & 4 deletions docs/src/assets/scss/docs.scss
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
display: flex;
flex-direction: column;

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: grid;
grid-template-columns: minmax(250px, 1fr) minmax(0, 3.5fr);
align-items: stretch;
Expand All @@ -33,7 +33,7 @@
grid-auto-rows: max-content;
align-items: start;

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
padding: var(--space-l-xl) 0;
padding-right: var(--space-s-l);
padding-inline-end: var(--space-s-l);
Expand All @@ -54,7 +54,7 @@
grid-gap: 1rem;
}

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
padding: 0;
}

Expand All @@ -74,7 +74,7 @@
border-inline-end: 1px solid var(--divider-color);
}

@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
padding: var(--space-l-xl) var(--space-l-2xl);
}
}
Expand Down
2 changes: 1 addition & 1 deletion docs/src/assets/scss/tokens/spacing.scss
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
--fluid-bp: calc((var(--fluid-screen) - var(--fluid-min-width) / 16 * 1rem) / (var(--fluid-max-width) - var(--fluid-min-width)));
}

@media screen and (min-width: 1023px) {
@media screen and (min-width: 1024px) {
:root {
--fluid-screen: calc(var(--fluid-max-width) * 1px);
}
Expand Down
4 changes: 2 additions & 2 deletions docs/src/assets/scss/utilities.scss
View file
Open in desktop
@@ -1,5 +1,5 @@
.grid {
@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: grid;
grid-template-columns: repeat(12, 1fr);
grid-gap: 2rem;
Expand All @@ -23,7 +23,7 @@
}

.mobile-only {
@media all and (min-width: 1023px) {
@media all and (min-width: 1024px) {
display: none;
}
}
Expand Down