Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use-dart-sass instead of node-sass #15912

Merged
merged 2 commits into from May 25, 2022
Merged

docs: use-dart-sass instead of node-sass #15912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b5e9ff
docs: use-dart-sass instead of node-sass
DeepshikaS May 24, 2022
fd868e8
Update dart-sass to sass latest version
DeepshikaS May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/package.json
View file
Open in desktop
Expand Up @@ -8,9 +8,9 @@
"license": "ISC",
"scripts": {
"images": "imagemin '_site/assets/images' --out-dir='_site/assets/images'",
"watch:sass": "node-sass --watch src/assets/scss -o src/assets/css",
"watch:sass": "sass --watch --poll src/assets/scss:src/assets/css",
"watch:eleventy": "eleventy --serve --port=2023",
"build:sass": "node-sass src/assets/scss -o src/assets/css",
"build:sass": "sass --style=compressed src/assets/scss:src/assets/css --no-source-map",
"build:eleventy": "npx @11ty/eleventy",
"start": "npm-run-all build:sass --parallel watch:* --parallel images",
"build": "npm-run-all build:sass --parallel build:* --parallel images"
Expand All @@ -22,6 +22,7 @@
"@11ty/eleventy-plugin-rss": "^1.1.1",
"@11ty/eleventy-plugin-syntaxhighlight": "^3.1.2",
"algoliasearch": "^4.12.1",
"dart-sass": "^1.25.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dart-sass": "^1.25.0",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dart-sass has been renamed to sass. Already we have sass.

"dom-parser": "^0.1.6",
"eleventy-plugin-nesting-toc": "^1.3.0",
"eleventy-plugin-page-assets": "^0.3.0",
Expand All @@ -31,10 +32,9 @@
"markdown-it": "^12.2.0",
"markdown-it-anchor": "^8.1.2",
"netlify-cli": "^10.3.1",
"node-sass": "^6.0.1",
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2",
"sass": "^1.38.0",
"slugify": "^1.6.3"
}
}
}
2 changes: 2 additions & 0 deletions docs/src/assets/scss/tokens/themes.scss
View file
Open in desktop
Expand Up @@ -93,6 +93,7 @@
}

@media (prefers-color-scheme: dark) {
html{
--secondary-button-background-color: var(--color-neutral-700);
--secondary-button-hover-color: var(--color-neutral-800);
--secondary-button-text-color: var(--body-text-color);
Expand All @@ -113,6 +114,7 @@
--hero-background-color: var(--color-neutral-800);
--footer-background-color: var(--color-neutral-800);
--outline-color: #fff;
}
}


Expand Down