Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: keep # fragments in Further Reading links on new docs site #15888

Closed
wants to merge 1 commit into from

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented May 18, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

We are using got and metascraper to determine final URLs for "Further Reading" links, but during the process # fragments from original links may have been lost.

For example, the last Further Reading link in no-iterator docs should point to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Deprecated_and_obsolete_features#Object_methods

What changes did you make? (Give an overview)

Updated the link shortcode to keep fragments from original links.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added the chore This change is not user-facing label May 18, 2022
@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 23af3b2
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6285285747e52d0008030d53
😎 Deploy Preview https://deploy-preview-15888--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdjermanovic
Copy link
Member Author

This change does affect the page reported by the Mixed Content check, but this change didn't cause that particular error.

@nzakas
Copy link
Member

nzakas commented May 19, 2022

I think #15890 already addresses this?

@mdjermanovic
Copy link
Member Author

Yes, it does, I'm closing this in favor of #15890.

@mdjermanovic mdjermanovic deleted the keep-fragments branch June 9, 2022 09:16
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 16, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants