New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add destructuredArrayIgnorePattern
option in no-unused-vars
#15649
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
2babca8
feat: add `destructuredArrayIgnorePattern` option in `no-unused-vars`
snitin315 2a8de61
docs: add `destructuredArrayIgnorePattern` option in `no-unused-vars`
snitin315 74ffd7f
fix: remove false positives and false negatives
snitin315 a84c10a
docs: update
snitin315 0c8a455
test: add more cases
snitin315 349a728
docs: update
snitin315 c2a8829
fix: remove false positives
snitin315 3291527
docs: update
snitin315 84612e5
feat: improve error message
snitin315 41102f8
feat: cover more cases
snitin315 6e6e1a6
docs: add more example
snitin315 1cf3d93
refactor: code
snitin315 3a1a4b2
fix: check for all references
snitin315 e755d3f
docs: add more examples
snitin315 bcebe25
chore: apply suggestions from code review
snitin315 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm confused. in an array pattern, you never need an unused variable, you just omit the binding - ie,
[, x]
etc. Why would you ever want an exception here?It's only in object destructuring that omitting the binding has a use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rationale for this option is in Additional Comments of the original post in #15611.
This is optional behavior, unused variables in array patterns are not ignored by default. Users who prefer elisions can simply not enable this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this is a style option, added after the prohibition on such things?