Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use node v16 for Verify Files #15364

Merged
merged 2 commits into from Nov 29, 2021
Merged

ci: use node v16 for Verify Files #15364

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a895800
ci: use node `v16`
snitin315 Nov 28, 2021
1cbbd72
ci: keep using node v12 for browser test
snitin315 Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '14.x'
node-version: '16.x'
- name: Install Packages
run: npm install
- name: Lint Files
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '12'
node-version: '16.x'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still using Node 12 to build the site (including demo), so it might be better to keep 12 here until we update that on Netlify.

https://app.netlify.com/sites/eslint/deploys/61a2da6c120b9b0008f32b86

2:25:57 AM: Now using node v12.22.7 (npm v6.14.15)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update it on Netlifly soon.

- name: Install Packages
run: npm install
- name: Test
Expand Down