Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add rule no-constant-binary-expression #15296

Merged
merged 15 commits into from Apr 22, 2022
Merged

feat: Add rule no-constant-binary-expression #15296

merged 15 commits into from Apr 22, 2022

Commits on Apr 7, 2022

  1. feat: Add rule no-constant-binary-expression 

    I proposed the core idea of this rule in
eslint#13752 as an addition to
`no-constant-condition`, but on the advice of the TSC, it was
restructured as a standalone rule.
    @captbaritone
    captbaritone committed Apr 7, 2022
    Copy the full SHA
    dc41817 View commit details
    Browse the repository at this point in the history

  2. Share no-constant-condition's isConstant 

    Here we extract `isConstant` into ast-utils and share it between
`no-constant-condition` and `no-constant-binary-expression`.
    @captbaritone
    captbaritone committed Apr 7, 2022
    Copy the full SHA
    6763d1e View commit details
    Browse the repository at this point in the history

  3. Update title of docs page

    @captbaritone
    captbaritone committed Apr 7, 2022
    Copy the full SHA
    c6b48f5 View commit details
    Browse the repository at this point in the history

  4. Avoid false positive on shadowed builtins

    @captbaritone
    captbaritone committed Apr 7, 2022
    Copy the full SHA
    969da25 View commit details
    Browse the repository at this point in the history

  5. Use isLogicalAssignmentOperator

    @captbaritone
    captbaritone committed Apr 7, 2022
    Copy the full SHA
    736b51f View commit details
    Browse the repository at this point in the history

  6. Ensure we don't treat user defined new expressions as always new

    @captbaritone
    captbaritone committed Apr 7, 2022
    Copy the full SHA
    dae6d75 View commit details
    Browse the repository at this point in the history

  7. Move docs to the new docs directory

    @captbaritone
    captbaritone committed Apr 7, 2022
    Copy the full SHA
    fec546d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Address review feedback

    @captbaritone
    captbaritone committed Apr 9, 2022
    Copy the full SHA
    d12da73 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Address more review feedback

    @captbaritone
    captbaritone committed Apr 19, 2022
    Copy the full SHA
    a8a0c6d View commit details
    Browse the repository at this point in the history

  2. Address review feedback

    @captbaritone
    captbaritone committed Apr 19, 2022
    Copy the full SHA
    4d449e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Fix typo

    @captbaritone
    captbaritone committed Apr 21, 2022
    Copy the full SHA
    b1c366b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. Update lib/rules/utils/ast-utils.js 

    Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
    @captbaritone @nzakas
    captbaritone and nzakas committed Apr 22, 2022
    Copy the full SHA
    c13329f View commit details
    Browse the repository at this point in the history

  2. Update docs/src/rules/no-constant-binary-expression.md 

    Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
    @captbaritone @nzakas
    captbaritone and nzakas committed Apr 22, 2022
    Copy the full SHA
    e35e44f View commit details
    Browse the repository at this point in the history

  3. Update docs/src/rules/no-constant-binary-expression.md 

    Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
    @captbaritone @nzakas
    captbaritone and nzakas committed Apr 22, 2022
    Copy the full SHA
    e3347b1 View commit details
    Browse the repository at this point in the history

  4. Update docs/src/rules/no-constant-binary-expression.md 

    Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
    @captbaritone @nzakas
    captbaritone and nzakas committed Apr 22, 2022
    Copy the full SHA
    2abd681 View commit details
    Browse the repository at this point in the history