Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: add node v17 #15193

Merged
merged 2 commits into from Oct 21, 2021
Merged

Build: add node v17 #15193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c6bef
Build: add node v17
aladdin-add Oct 20, 2021
72e4b53
fix: npm install --force when node v17
aladdin-add Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [16.x, 14.x, 12.x, "12.22.0"]
node: [17.x, 16.x, 14.x, 12.x, "12.22.0"]
include:
- os: windows-latest
node: "12.x"
Expand All @@ -43,10 +43,10 @@ jobs:
- name: Install Packages
run: npm install
# TODO(btmills): Remove Node 16 --force branching after releasing v8.0.0 final.
if: ${{ !startswith(matrix.node, '16') }}
if: ${{ !startswith(matrix.node, '16') && !startswith(matrix.node, '17') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above this line indicates we should be able to remove all checks for Node 16? So we probably don’t need to add Node 17, just remove the Node 16 stuff?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen in here, eslint-plugin-jsdoc has not not fully supported eslint v8 yet. We will have to wait it been fixed: gajus/eslint-plugin-jsdoc#791

- name: Install Packages
run: npm install --force
if: ${{ startswith(matrix.node, '16') }}
if: ${{ startswith(matrix.node, '16') || startswith(matrix.node, '17') }}
- name: Test
run: node Makefile mocha
- name: Fuzz Test
Expand Down