New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for private-in syntax (fixes #14811) #15060
Conversation
|
Hi @ota-meshi!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! We just need to release espree and update package.json, and then this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Espree was just updated in #15338, so this is good to go! LGTM
WIP
Remaining steps:
Fixes #14811.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Upgrade the espree.
What changes did you make? (Give an overview)
This PR adds support for ES2022 private-in.
I have changed the
space-unary-ops
rule that we know needs to be changed.Is there anything you'd like reviewers to focus on?
I checked keyword-spacing rule, which is similar to space-unary-ops rule, but the rule already seems to work well with
return#x in obj
.