Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: LintMessage.line and column are possibly undefined #15032

Merged
merged 1 commit into from Sep 10, 2021

Commits on Sep 6, 2021

  1. Docs: LintMessage.line and column are possibly undefined

    In `lib/linter/linter.js`, the `parse()` function's exception handler
    translates the exception's message to a `LintMessage`. It also passes
    through the exception's `lineNumber` and `column`, but the exception is
    not guaranteed to have those properties. In that case,
    `LintMessage.line` and `column` can be `undefined`.
    
    In eslint/eslint-plugin-markdown#191, the processor would crash when
    attempting to map messages without a line.
    
    Normally widening a type like this would be a breaking change, but since
    this is only updating the docs to reflect reality, I think this can be a
    semver-patch change.
    btmills committed Sep 6, 2021
    Copy the full SHA
    7a19d4a View commit details
    Browse the repository at this point in the history