Chore: Removed lodash.merge #14931
Closed
Chore: Removed lodash.merge #14931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
snitin315
requested changes
Aug 15, 2021
|
@jimmywarting you have linting and testing errors. Can you please take a look? (You can try things out locally by running |
1 task
mdjermanovic
added
chore
mdjermanovic
requested changes
Aug 19, 2021
| @@ -45,6 +45,7 @@ const DEFAULT_ECMA_VERSION = 5; | |||
| const commentParser = new ConfigCommentParser(); | |||
| const DEFAULT_ERROR_LOC = { start: { line: 1, column: 0 }, end: { line: 1, column: 1 } }; | |||
| const parserSymbol = Symbol.for("eslint.RuleTester.parser"); | |||
| const merge = Object.assign; | |||
There was a problem hiding this comment.
We can't replace here lodash.merge with Object.assign , because merge() is used to merge parserOptions, which should be deeply merged. I added a test case that would fail with Object.assign in #14948.
There was a problem hiding this comment.
Guess we can close this PR then cuz Object.assign don't cut it...
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Addresses part of #14098. Removes lodash from the project