Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: no-new-func rule catching eval case of MemberExpression #14860

Merged
merged 16 commits into from Sep 23, 2021
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions docs/rules/no-new-func.md
@@ -1,12 +1,16 @@
# Disallow Function Constructor (no-new-func)

It's possible to create functions in JavaScript using the `Function` constructor, such as:
It's possible to create functions in JavaScript from strings at runtime using `Function` constructors, such as:
archmoj marked this conversation as resolved.
Show resolved Hide resolved

```js
var x = new Function("a", "b", "return a + b");
var x = Function("a", "b", "return a + b");
var x = Function.call(null, "a", "b", "return a + b");
var x = Function.apply(null, ["a", "b", "return a + b"]);
var x = Function.bind(null, "a", "b", "return a + b")();
```

This is considered by many to be a bad practice due to the difficulty in debugging and reading these types of functions.
This is considered by many to be a bad practice due to the difficulty in debugging and reading these types of functions. In addition, Content-Security-Policy (CSP) directives may disallow the use of eval() and similar methods for creating code from strings.

## Rule Details

Expand All @@ -19,6 +23,9 @@ Examples of **incorrect** code for this rule:

var x = new Function("a", "b", "return a + b");
var x = Function("a", "b", "return a + b");
var x = Function.call(null, "a", "b", "return a + b");
var x = Function.apply(null, ["a", "b", "return a + b"]);
var x = Function.bind(null, "a", "b", "return a + b")();
archmoj marked this conversation as resolved.
Show resolved Hide resolved
```

Examples of **correct** code for this rule:
Expand Down
22 changes: 17 additions & 5 deletions lib/rules/no-new-func.js
Expand Up @@ -38,12 +38,24 @@ module.exports = {
variable.references.forEach(ref => {
const node = ref.identifier;
const { parent } = node;
let isEval = false;

if (
parent &&
(parent.type === "NewExpression" || parent.type === "CallExpression") &&
node === parent.callee
) {
if (parent) {
if (node === parent.callee && (
parent.type === "NewExpression" ||
parent.type === "CallExpression"
)) {
isEval = true;
} else if (parent.type === "MemberExpression") {
const gParent = parent.parent;

if (gParent && gParent.type === "CallExpression") {
isEval = true;
}
}
mdjermanovic marked this conversation as resolved.
Show resolved Hide resolved
}

if (isEval) {
context.report({
node: parent,
mdjermanovic marked this conversation as resolved.
Show resolved Hide resolved
messageId: "noFunctionConstructor"
Expand Down
21 changes: 21 additions & 0 deletions tests/lib/rules/no-new-func.js
Expand Up @@ -55,6 +55,27 @@ ruleTester.run("no-new-func", rule, {
type: "CallExpression"
}]
},
{
mdjermanovic marked this conversation as resolved.
Show resolved Hide resolved
code: "var a = Function.call(null, \"b\", \"c\", \"return b+c\");",
errors: [{
messageId: "noFunctionConstructor",
type: "MemberExpression"
}]
},
{
code: "var a = Function.apply(null, [\"b\", \"c\", \"return b+c\"]);",
errors: [{
messageId: "noFunctionConstructor",
type: "MemberExpression"
}]
},
{
code: "var a = Function.bind(null, \"b\", \"c\", \"return b+c\")();",
mdjermanovic marked this conversation as resolved.
Show resolved Hide resolved
errors: [{
messageId: "noFunctionConstructor",
type: "MemberExpression"
}]
},
{
code: "const fn = () => { class Function {} }; new Function('', '')",
parserOptions: {
Expand Down