Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Unlock @babel/code-frame #14794

Closed
wants to merge 1 commit into from
Closed

Conversation

camsong
Copy link

@camsong camsong commented Jul 13, 2021

@babel/core use @babel/code-frame@^7.14.5 right now https://github.com/babel/babel/blob/bfcf783834cbe293ca540e84c1ad285ed2e728e2/packages/babel-core/package.json#L51
which always cause 2 versions of @babel/code-frame

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Upgrade - for a dependency upgrade.
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jul 13, 2021
@eslint-github-bot
Copy link

Hi @camsong!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @camsong!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@camsong camsong changed the title Unlock @babel/code-frame Upgrade: Unlock @babel/code-frame Jul 13, 2021
@eslint-github-bot
Copy link

Hi @camsong!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@babel/core use `@babel/code-frame@^7.14.5` right now https://github.com/babel/babel/blob/bfcf783834cbe293ca540e84c1ad285ed2e728e2/packages/babel-core/package.json#L51
which always cause 2 versions of `@babel/code-frame`
@mdjermanovic mdjermanovic added works as intended The behavior described in this issue is working correctly and removed triage An ESLint team member will look at this issue soon labels Jul 13, 2021
@mdjermanovic
Copy link
Member

Hi @camsong, thanks for the PR!

@babel/code-frame dependency is intentionally locked at 7.12.11 because newer versions produce different outputs and that's a breaking change for ESLint's codeframe formatter. Please find more details in #14067.

which always cause 2 versions of @babel/code-frame

ESLint v8.0.0 will remove the codeframe formatter and @babel/code-frame dependency (#14277) so this will be no longer an issue.

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 10, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion works as intended The behavior described in this issue is working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants