New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: Unlock @babel/code-frame #14794
Conversation
Hi @camsong!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
1 similar comment
Hi @camsong!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Hi @camsong!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
@babel/core use `@babel/code-frame@^7.14.5` right now https://github.com/babel/babel/blob/bfcf783834cbe293ca540e84c1ad285ed2e728e2/packages/babel-core/package.json#L51 which always cause 2 versions of `@babel/code-frame`
Hi @camsong, thanks for the PR!
ESLint v8.0.0 will remove the |
@babel/core use
@babel/code-frame@^7.14.5
right now https://github.com/babel/babel/blob/bfcf783834cbe293ca540e84c1ad285ed2e728e2/packages/babel-core/package.json#L51which always cause 2 versions of
@babel/code-frame
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Upgrade - for a dependency upgrade.
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?