Revert "Update: ecmaVersion defaults to 5, and allows "latest" (#14622)" #14711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
bug
mdjermanovic
approved these changes
Jun 16, 2021
btmills
approved these changes
Jun 17, 2021
mdjermanovic
added
accepted
snitin315
approved these changes
Jun 18, 2021
aladdin-add
added a commit
to aladdin-add/eslint
that referenced
this pull request
Jun 18, 2021
eslint#14622)" (eslint#14711)" This reverts commit 97d9bd2.
aladdin-add
added a commit
to aladdin-add/eslint
that referenced
this pull request
Jun 24, 2021
eslint#14622)" (eslint#14711)" This reverts commit 97d9bd2.
mdjermanovic
pushed a commit
that referenced
this pull request
Jun 26, 2021
* Revert "Revert "Update: ecmaVersion defaults to 5, and allows "latest" (#14622)" (#14711)" This reverts commit 97d9bd2. * chore: use parser.$parser to check if it's espree * chore: add some tests * chore: not set default 5 * chore: make the $parser non-enumerable * chore: use symbol * chore: a small refactor
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 831f6b3.
it causes an issue in rule-tester(reported in #14710). there are some ways to fix it, but we have not reached consensus which way to go.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?