Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: highlight last write reference for no-unused-vars (fixes #14324) #14335

Merged
merged 6 commits into from Apr 23, 2021
Merged

Update: highlight last write reference for no-unused-vars (fixes #14324) #14335

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77aa1fc
Fix: highlight last write reference for no-unused-vars (fixes #14324)
snitin315 Apr 17, 2021
9f413c0
test: updates
snitin315 Apr 17, 2021
8766ede
Chore: add test case
snitin315 Apr 17, 2021
616e78e
Fix: apply suggestions
snitin315 Apr 22, 2021
2fea2da
Chore: update tests
snitin315 Apr 22, 2021
54a96c1
Chore: more tests
snitin315 Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 19 additions & 3 deletions lib/rules/no-unused-vars.js
View file
Open in desktop
Expand Up @@ -624,10 +624,26 @@ module.exports = {

// Report the first declaration.
if (unusedVar.defs.length > 0) {
let writeReferences;

if (unusedVar.references.length > 0) {
writeReferences = unusedVar.references.filter(ref => ref.isWrite());
}
snitin315 marked this conversation as resolved.
Show resolved Hide resolved

let referenceToReport;

if (unusedVar.references.length) {

// report last write reference, https://github.com/eslint/eslint/issues/14324
if (Array.isArray(writeReferences) && writeReferences.length) {
referenceToReport = writeReferences[writeReferences.length - 1];
snitin315 marked this conversation as resolved.
Show resolved Hide resolved
} else {
referenceToReport = unusedVar.references[unusedVar.references.length - 1];
}
snitin315 marked this conversation as resolved.
Show resolved Hide resolved
}

context.report({
node: unusedVar.references.length ? unusedVar.references[
unusedVar.references.length - 1
].identifier : unusedVar.identifiers[0],
node: unusedVar.references.length ? referenceToReport.identifier : unusedVar.identifiers[0],
snitin315 marked this conversation as resolved.
Show resolved Hide resolved
messageId: "unusedVar",
data: unusedVar.references.some(ref => ref.isWrite())
? getAssignedMessageData(unusedVar)
Expand Down
17 changes: 12 additions & 5 deletions tests/lib/rules/no-unused-vars.js
View file
Open in desktop
Expand Up @@ -1062,7 +1062,7 @@ ruleTester.run("no-unused-vars", rule, {
code: `let myArray = [1,2,3,4].filter((x) => x == 0);
myArray = myArray.filter((x) => x == 1);`,
parserOptions: { ecmaVersion: 2015 },
errors: [{ ...assignedError("myArray"), line: 2, column: 15 }]
errors: [{ ...assignedError("myArray"), line: 2, column: 5 }]
},
{
code: "const a = 1; a += 1;",
Expand All @@ -1071,21 +1071,28 @@ ruleTester.run("no-unused-vars", rule, {
},
{
code: "var a = function() { a(); };",
errors: [{ ...assignedError("a"), line: 1, column: 22 }]
errors: [{ ...assignedError("a"), line: 1, column: 5 }]
},
{
code: "var a = function(){ return function() { a(); } };",
errors: [{ ...assignedError("a"), line: 1, column: 41 }]
errors: [{ ...assignedError("a"), line: 1, column: 5 }]
},
{
code: "const a = () => { a(); };",
parserOptions: { ecmaVersion: 2015 },
errors: [{ ...assignedError("a"), line: 1, column: 19 }]
errors: [{ ...assignedError("a"), line: 1, column: 7 }]
},
{
code: "const a = () => () => { a(); };",
parserOptions: { ecmaVersion: 2015 },
errors: [{ ...assignedError("a"), line: 1, column: 25 }]
errors: [{ ...assignedError("a"), line: 1, column: 7 }]
},

// https://github.com/eslint/eslint/issues/14324
{
code: "let x = [];\nx = x.concat(x);",
parserOptions: { ecmaVersion: 2015 },
errors: [{ ...assignedError("x"), line: 2, column: 1 }]
},
{

Expand Down