Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Require specific semver functions #14215

Closed
wants to merge 1 commit into from

Conversation

fregante
Copy link
Contributor

Semi-related to #14098

This doesn't remove any dependencies, but it helps with startup times (a lil bit) since ESLint now doesn't have to load every single semver file.

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Mar 15, 2021
@nzakas
Copy link
Member

nzakas commented Mar 19, 2021

This file is primarily used for releases so it doesn’t have any influence over ESLint run time. As such, I’d prefer to keep it as-is for clarity.

@nzakas nzakas closed this Mar 19, 2021
@fregante
Copy link
Contributor Author

fregante commented Mar 19, 2021

Silly me, I meant to change https://github.com/eslint/eslint/blob/179a910b32e853bc12a9dd71f7c10e762cbeac44/lib/init/config-initializer.js instead of this

I'll send another PR if you don't mind, or I can update this one

@fregante fregante deleted the short-semver branch March 19, 2021 01:20
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Sep 16, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants