Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: add autofix to rule multiline-ternary #13958

Merged
merged 9 commits into from Dec 31, 2020
Merged

Update: add autofix to rule multiline-ternary #13958

merged 9 commits into from Dec 31, 2020

Commits on Dec 24, 2020

  1. Update: Added auto-fix to multiline-ternary 

    I noticed unfixed warnings from this ESLint rule and wanted to auto-fix them. While it may seem like doing `'\n? '` is opinionated, I did have changed to make this take a new option and either put the `?` on the previous line or next line. This is actually unnecessary because `operator-linebreak` handles it for you.
    @Sawtaytoes @aladdin-add
    Sawtaytoes authored and aladdin-add committed Dec 24, 2020
    Copy the full SHA
    2ad85a3 View commit details
    Browse the repository at this point in the history

  2. chore: fix linting

    @aladdin-add
    aladdin-add committed Dec 24, 2020
    Copy the full SHA
    121c8f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2020

  1. chore: review suggestions

    @aladdin-add
    aladdin-add committed Dec 26, 2020
    Copy the full SHA
    5bb8d3b View commit details
    Browse the repository at this point in the history

  2. Chore: review suggestions 

    refs: https://github.com/eslint/eslint/pull/12982/files#r409035292
    @aladdin-add
    aladdin-add committed Dec 26, 2020
    Copy the full SHA
    0938bbf View commit details
    Browse the repository at this point in the history

  3. Chore: add a test incluing comments

    @aladdin-add
    aladdin-add committed Dec 26, 2020
    Copy the full SHA
    a14532e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Chore: review suggestions

    @aladdin-add
    aladdin-add committed Dec 28, 2020
    Copy the full SHA
    d4de345 View commit details
    Browse the repository at this point in the history

  2. Chore: fixer.replaceTextRange() => removeRange()

    @aladdin-add
    aladdin-add committed Dec 28, 2020
    Copy the full SHA
    c798c4b View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. chore: review suggestions

    @aladdin-add
    aladdin-add committed Dec 29, 2020
    Copy the full SHA
    7f96dde View commit details
    Browse the repository at this point in the history

  2. chore: fix typo

    @aladdin-add
    aladdin-add committed Dec 29, 2020
    Copy the full SHA
    0e7d4c6 View commit details
    Browse the repository at this point in the history