Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: no-useless-escape wrong loc and fix with CRLF in template elements #13953

Merged
merged 1 commit into from Dec 30, 2020
Merged

Fix: no-useless-escape wrong loc and fix with CRLF in template elements #13953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rules/no-useless-escape.js
View file
Open in desktop
Expand Up @@ -172,7 +172,7 @@ module.exports = {
}

if (isUnnecessaryEscape && !isQuoteEscape) {
report(node, match.index + 1, match[0].slice(1));
report(node, match.index, match[0].slice(1));
}
}

Expand Down Expand Up @@ -206,7 +206,7 @@ module.exports = {
return;
}

const value = isTemplateElement ? node.value.raw : node.raw.slice(1, -1);
const value = isTemplateElement ? sourceCode.getText(node) : node.raw;
const pattern = /\\[^\d]/gu;
let match;

Expand Down
90 changes: 90 additions & 0 deletions tests/lib/rules/no-useless-escape.js
View file
Open in desktop
Expand Up @@ -955,6 +955,96 @@ ruleTester.run("no-useless-escape", rule, {
}]
}]
},
{
code: "`multiline template\r\nliteral with useless \\escape`",
parserOptions: { ecmaVersion: 6 },
errors: [{
line: 2,
column: 22,
endColumn: 23,
message: "Unnecessary escape character: \\e.",
type: "TemplateElement",
suggestions: [{
messageId: "removeEscape",
output: "`multiline template\r\nliteral with useless escape`"
}, {
messageId: "escapeBackslash",
output: "`multiline template\r\nliteral with useless \\\\escape`"
}]
}]
},
{
code: "`template literal with line continuation \\\nand useless \\escape`",
parserOptions: { ecmaVersion: 6 },
errors: [{
line: 2,
column: 13,
endColumn: 14,
message: "Unnecessary escape character: \\e.",
type: "TemplateElement",
suggestions: [{
messageId: "removeEscape",
output: "`template literal with line continuation \\\nand useless escape`"
}, {
messageId: "escapeBackslash",
output: "`template literal with line continuation \\\nand useless \\\\escape`"
}]
}]
},
{
code: "`template literal with line continuation \\\r\nand useless \\escape`",
parserOptions: { ecmaVersion: 6 },
errors: [{
line: 2,
column: 13,
endColumn: 14,
message: "Unnecessary escape character: \\e.",
type: "TemplateElement",
suggestions: [{
messageId: "removeEscape",
output: "`template literal with line continuation \\\r\nand useless escape`"
}, {
messageId: "escapeBackslash",
output: "`template literal with line continuation \\\r\nand useless \\\\escape`"
}]
}]
},
{
code: "`template literal with mixed linebreaks \r\r\n\n\\and useless escape`",
parserOptions: { ecmaVersion: 6 },
errors: [{
line: 4,
column: 1,
endColumn: 2,
message: "Unnecessary escape character: \\a.",
type: "TemplateElement",
suggestions: [{
messageId: "removeEscape",
output: "`template literal with mixed linebreaks \r\r\n\nand useless escape`"
}, {
messageId: "escapeBackslash",
output: "`template literal with mixed linebreaks \r\r\n\n\\\\and useless escape`"
}]
}]
},
{
code: "`template literal with mixed linebreaks in line continuations \\\n\\\r\\\r\n\\and useless escape`",
parserOptions: { ecmaVersion: 6 },
errors: [{
line: 4,
column: 1,
endColumn: 2,
message: "Unnecessary escape character: \\a.",
type: "TemplateElement",
suggestions: [{
messageId: "removeEscape",
output: "`template literal with mixed linebreaks in line continuations \\\n\\\r\\\r\nand useless escape`"
}, {
messageId: "escapeBackslash",
output: "`template literal with mixed linebreaks in line continuations \\\n\\\r\\\r\n\\\\and useless escape`"
}]
}]
},
{
code: "`\\a```",
parserOptions: { ecmaVersion: 6 },
Expand Down