Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Add disallowTemplateShorthand option in no-implicit-coercion #13579

Merged
merged 11 commits into from Apr 9, 2021
Merged

Update: Add disallowTemplateShorthand option in no-implicit-coercion #13579

merged 11 commits into from Apr 9, 2021

Commits on Apr 5, 2021

  1. Update: Add templateString option in no-implicit-coercion (fixes esli… 

    …nt#12866)

This adds the `templateString` option to `no-implicit-coercion`. This makes the
rule report the following code:

```js
`${foo}`
```

For backwards compatibility, this was added as a separate option instead of as
default behaviour.
    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    4350ec1 View commit details
    Browse the repository at this point in the history

  2. Fix no-implicit-coercion templateString examples

    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    bdfe13e View commit details
    Browse the repository at this point in the history

  3. Skip tagged template strings in no-implicit-coercion

    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    bd6f9b4 View commit details
    Browse the repository at this point in the history

  4. Add missing tests for no-implicit-coercion

    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    afe1805 View commit details
    Browse the repository at this point in the history

  5. Used cooked template string values

    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    07d1b9f View commit details
    Browse the repository at this point in the history

  6. Add missing documentation for no-implicit-coercion 

    Note that the `templateString` option isn’t affected by the `string` option.
    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    ce1d62b View commit details
    Browse the repository at this point in the history

  7. Add missing tests for no-implicit-coercion templateString

    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    05f3cea View commit details
    Browse the repository at this point in the history

  8. Rename templateString to disallowTemplateString

    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    e52cab6 View commit details
    Browse the repository at this point in the history

  9. Fix typo in no-implicit-coercion docs

    @remcohaszing
    remcohaszing committed Apr 5, 2021
    Copy the full SHA
    3592c58 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Add tagged template string example for no-implicit-coercion

    @remcohaszing
    remcohaszing committed Apr 6, 2021
    Copy the full SHA
    4dcf42d View commit details
    Browse the repository at this point in the history

  2. Update docs/rules/no-implicit-coercion.md 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @remcohaszing @mdjermanovic
    remcohaszing and mdjermanovic committed Apr 6, 2021
    Copy the full SHA
    a23054f View commit details
    Browse the repository at this point in the history