Update: require meta
for fixable rules in RuleTester (refs #13349)
#13489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Add something to the core
refs #13349, fixes step 2 from this comment.
This PR updates RuleTester to require
meta
property in fixable rules.What changes did you make? (Give an overview)
An
invalid
test case, where the rule being tested has fixed the given code, will now fail if the rule doesn't havemeta
property.Is there anything you'd like reviewers to focus on?
RuleTester
still doesn't check formeta.fixable
, because linter already throws an error if the rule that provided a fix does havemeta
but doesn't havemeta.fixable
.This change doesn't affect legacy-format rules (functions). They will be still allowed to make fixes. I guess that was decided?