Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) #13180

cmal · 2020-04-14T14:18:30Z

Prerequisites checklist

I have read the contributing guidelines.
The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix the issue here: #12758

Is there anything you'd like reviewers to focus on?

I thought two nodes are mergable only when one is ImportNamespaceSpecifier and one is ImportSpecifier, is that true?
I thought only in handleImports when checking importsInFile should I change the checkAndReport function, is that true?

jsf-clabot · 2020-04-14T14:18:33Z

All committers have signed the CLA.

docs/rules/no-duplicate-imports.md

nzakas · 2020-06-11T18:45:25Z

Sorry, looks like we missed this PR! @mdjermanovic you reopened the issue related to this PR, can you take a look?

cmal · 2020-06-29T03:24:39Z

👍

* Fix: typo in docs/rules/no-duplicate-imports.md

mdjermanovic

Thanks for the PR! I left some notes.

In this PR we should also check how the new logic affects exports, fix #12760, and account for the new export * as ns syntax.

I'll try to make an overview on what should and what shouldn't be reported by this rule.

lib/rules/no-duplicate-imports.js

mdjermanovic · 2020-06-29T15:01:39Z

lib/rules/no-duplicate-imports.js

+function isTwoNodesCanMerge(node1, node2) {
+    return (
+        (
+            checkImportType(node1, "ImportNamespaceSpecifier") &&
+            checkImportType(node2, "ImportSpecifier")
+        ) ||
+        (
+            checkImportType(node1, "ImportSpecifier") &&
+            checkImportType(node2, "ImportNamespaceSpecifier")
+        )
+    );
+}


Looks like this function is actually doing the opposite of its name: checks if two nodes cannot be merged?

nzakas · 2020-07-07T20:15:45Z

@cmal there are a couple of changes requested. Can you please take a look?

cmal · 2020-09-14T15:46:34Z

OK, sorry for late. I'll have a look.

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

mdjermanovic · 2021-03-22T01:30:35Z

Closing due to inactivity. New PR: #14238

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

…slint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

…) (#14238) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760) * Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes #12760)

eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 14, 2020

cmal mentioned this pull request Apr 14, 2020

[no-duplicate-imports] Treat namespace imports as different #12758

Closed

aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Apr 16, 2020

nzakas changed the title ~~Fix: ignore unmergable imports when checking no-duplicate-imports~~ Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) Jun 11, 2020

nzakas reviewed Jun 11, 2020

View reviewed changes

docs/rules/no-duplicate-imports.md Outdated Show resolved Hide resolved

Fix: ignore unmergable imports when checking no-duplicate-imports

a33d27b

* Fix: typo in docs/rules/no-duplicate-imports.md

cmal force-pushed the master branch from a23e6ba to a33d27b Compare June 29, 2020 06:56

mdjermanovic requested changes Jun 29, 2020

View reviewed changes

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request Mar 21, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

5b9ef18

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request Mar 21, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

2f8b3d6

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

mdjermanovic closed this Mar 22, 2021

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request Mar 23, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

cdd9a45

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

75f7d51

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

d1704cd

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

2a86577

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

481a520

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

d065dda

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

68203fc

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

c485a09

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

0207042

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

6e494a1

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

d30fc24

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

4c07c89

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

ignore unmergable imports when checking no-duplicate-imports (fixes e…

92fc460

…slint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 9, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

096c75b

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 23, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

e20fab5

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 23, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

8f33a8b

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 23, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

2a54321

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 23, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

1932d2c

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 23, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

7bb7a50

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 27, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

9d3fd4d

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 27, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

f97848b

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 27, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

d515f8d

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

boutahlilsoufiane added a commit to boutahlilsoufiane/eslint that referenced this pull request May 30, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes

af199ef

eslint#13180) & Fix: Ignore re-export all in no-duplicate-imports (fixes eslint#12760)

saberduck mentioned this pull request Jun 23, 2021

Update dependencies SonarSource/SonarJS#2675

Closed

eslint-github-bot bot locked and limited conversation to collaborators Sep 19, 2021

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) #13180

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) #13180

cmal commented Apr 14, 2020 •

edited

jsf-clabot commented Apr 14, 2020 •

edited

nzakas commented Jun 11, 2020

cmal commented Jun 29, 2020

mdjermanovic left a comment

mdjermanovic Jun 29, 2020

nzakas commented Jul 7, 2020

cmal commented Sep 14, 2020

mdjermanovic commented Mar 22, 2021

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) #13180

Fix: ignore unmergable imports when checking no-duplicate-imports (fixes #13180) #13180

Conversation

cmal commented Apr 14, 2020 • edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

jsf-clabot commented Apr 14, 2020 • edited

nzakas commented Jun 11, 2020

cmal commented Jun 29, 2020

mdjermanovic left a comment

Choose a reason for hiding this comment

mdjermanovic Jun 29, 2020

Choose a reason for hiding this comment

nzakas commented Jul 7, 2020

cmal commented Sep 14, 2020

mdjermanovic commented Mar 22, 2021

cmal commented Apr 14, 2020 •

edited

jsf-clabot commented Apr 14, 2020 •

edited