New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: some (dev) deps #13155
Upgrade: some (dev) deps #13155
Conversation
2ead37c
to
20396ab
Compare
@@ -20,8 +20,8 @@ | |||
"homepage": "https://eslint.org", | |||
"bugs": "https://github.com/eslint/eslint/issues/", | |||
"peerDependencies": { | |||
"eslint-plugin-jsdoc": "^15.9.5", | |||
"eslint-plugin-node": "^9.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for catching this. I missed this in my PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, looks like my PR caused some merge conflicts.
1. after upgrading eslint-plugin-jsdoc, it reports: "Invalid JSDoc tag name "template" jsdoc/check-tag-names" it was fixed by added setting.jsdoc.mode: typescript (refs:https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names) 2. the following deps were not upgraded: * levn (was upgraded in #13140) * ignore (it has a few breaking change)
85ddffd
to
1947378
Compare
I've rebased master. @kaicataldo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
bce22ce
to
407601b
Compare
407601b
to
4793ae7
Compare
@kaicataldo has your feedback been addressed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
as the title.
Is there anything you'd like reviewers to focus on?
after upgrading eslint-plugin-jsdoc, it reports:
"Invalid JSDoc tag name "template" jsdoc/check-tag-names"
it was fixed by adding
setting.jsdoc.mode: "typescript"
(refs:https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names)
the following deps were not upgraded: