Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: no-extra-parens export default sequence expression false positive #13096

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix: no-extra-parens export default sequence expression false positive #13096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/rules/no-extra-parens.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,11 @@ module.exports = {
tokensToIgnore.add(secondToken);
}

if (hasExcessParens(node)) {
const hasExtraParens = node.parent.type === "ExportDefaultDeclaration"
? hasExcessParensWithPrecedence(node, PRECEDENCE_OF_ASSIGNMENT_EXPR)
: hasExcessParens(node);

if (hasExtraParens) {
report(node);
}
}
Expand Down
57 changes: 55 additions & 2 deletions tests/lib/rules/no-extra-parens.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,13 +530,17 @@ ruleTester.run("no-extra-parens", rule, {
"() => ({ foo: 1 }).foo",
"() => ({ foo: 1 }.foo().bar).baz.qux()",
"() => ({ foo: 1 }.foo().bar + baz)",
{
code: "export default (a, b)",
parserOptions: { sourceType: "module" }
},
{
code: "export default (function(){}).foo",
parserOptions: { ecmaVersion: 6, sourceType: "module" }
parserOptions: { sourceType: "module" }
},
{
code: "export default (class{}).foo",
parserOptions: { ecmaVersion: 6, sourceType: "module" }
parserOptions: { sourceType: "module" }
},
"({}).hasOwnProperty.call(foo, bar)",
"({}) ? foo() : bar()",
Expand Down Expand Up @@ -1358,6 +1362,55 @@ ruleTester.run("no-extra-parens", rule, {
"UpdateExpression",
1
),
invalid(
"export default ((a, b))",
"export default (a, b)",
"SequenceExpression",
1,
{ parserOptions: { sourceType: "module" } }
),
invalid(
"export default (() => {})",
"export default () => {}",
"ArrowFunctionExpression",
1,
{ parserOptions: { sourceType: "module" } }
),
invalid(
"export default ((a, b) => a + b)",
"export default (a, b) => a + b",
"ArrowFunctionExpression",
1,
{ parserOptions: { sourceType: "module" } }
),
invalid(
"export default (a => a)",
"export default a => a",
"ArrowFunctionExpression",
1,
{ parserOptions: { sourceType: "module" } }
),
invalid(
"export default (a = b)",
"export default a = b",
"AssignmentExpression",
1,
{ parserOptions: { sourceType: "module" } }
),
invalid(
"export default (a ? b : c)",
"export default a ? b : c",
"ConditionalExpression",
1,
{ parserOptions: { sourceType: "module" } }
),
invalid(
"export default (a)",
"export default a",
"Identifier",
1,
{ parserOptions: { sourceType: "module" } }
),
invalid(
"for (foo of(bar));",
"for (foo of bar);",
Expand Down