New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ignore marker-only comments in spaced-comment (fixes #12036) #12558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I have no concerns with the *
markers at this point, but let's see what other team members think.
I think this is reasonable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix #12036
What changes did you make? (Give an overview)
If the whole comment is equal to any of the specified markers, that comment will be ignored by this rule.
This applies to both line comments and block comments.
Is there anything you'd like reviewers to focus on?
This indirectly allows
/***/
and//*
("*"
is always a marker).