Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: invalid autofix in function-call-argument-newline (fixes #12454) #12539

Merged
merged 3 commits into from Nov 10, 2019
Merged

Fix: invalid autofix in function-call-argument-newline (fixes #12454) #12539

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d679dd8
Fix: invalid autofix in function-call-argument-newline (fixes #12454)
yeonjuan Nov 7, 2019
2404c7b
Add test case for multi line comments
yeonjuan Nov 9, 2019
c33034b
Fix typo
yeonjuan Nov 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/lib/rules/function-call-argument-newline.js
View file
Open in desktop
Expand Up @@ -390,6 +390,21 @@ ruleTester.run("function-call-argument-newline", rule, {
}
]
},
{
code: "fn(a,/* commeent */\nb)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but I’m assuming the intention was comment rather than commeent here 😄

Copy link
Member Author

@yeonjuan yeonjuan Nov 10, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaicataldo Oh it's typo. I fixed it. Thanks.

output: "fn(a,/* commeent */ b)",
options: ["never"],
parserOptions: { ecmaVersion: 6 },
errors: [
{
messageId: "unexpectedLineBreak",
line: 1,
column: 20,
endLine: 2,
endColumn: 1
}
]
},

/* "consistent" */
{
Expand Down