Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-useless-rename autofix removes comments #12300

Merged
merged 1 commit into from Sep 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/rules/no-useless-rename.js
Expand Up @@ -41,6 +41,8 @@ module.exports = {
ignoreImport = options.ignoreImport === true,
ignoreExport = options.ignoreExport === true;

const sourceCode = context.getSourceCode();

//--------------------------------------------------------------------------
// Helpers
//--------------------------------------------------------------------------
Expand All @@ -64,6 +66,9 @@ module.exports = {
type
},
fix(fixer) {
if (sourceCode.commentsExistBetween(initial, result)) {
return null;
}
return fixer.replaceTextRange([
initial.range[0],
result.range[1]
Expand Down
127 changes: 127 additions & 0 deletions tests/lib/rules/no-useless-rename.js
Expand Up @@ -299,6 +299,133 @@ ruleTester.run("no-useless-rename", rule, {
code: "export {foo as foo, bar as bar} from 'foo';",
output: "export {foo, bar} from 'foo';",
errors: ["Export foo unnecessarily renamed.", "Export bar unnecessarily renamed."]
},

// Should not autofix if it would remove comments
{
code: "({/* comment */foo: foo} = {});",
output: "({/* comment */foo} = {});",
errors: ["Destructuring assignment foo unnecessarily renamed."]
},
{
code: "({foo, /* comment */bar: bar} = {});",
output: "({foo, /* comment */bar} = {});",
errors: ["Destructuring assignment bar unnecessarily renamed."]
},
{
code: "({foo/**/ : foo} = {});",
output: null,
errors: ["Destructuring assignment foo unnecessarily renamed."]
},
{
code: "({foo /**/: foo} = {});",
output: null,
errors: ["Destructuring assignment foo unnecessarily renamed."]
},
{
code: "({foo://\nfoo} = {});",
output: null,
errors: ["Destructuring assignment foo unnecessarily renamed."]
},
{
code: "({foo: /**/foo} = {});",
output: null,
errors: ["Destructuring assignment foo unnecessarily renamed."]
},
{
code: "({foo: foo/* comment */} = {});",
output: "({foo/* comment */} = {});",
errors: ["Destructuring assignment foo unnecessarily renamed."]
},
{
code: "({foo: foo//comment\n,bar} = {});",
output: "({foo//comment\n,bar} = {});",
errors: ["Destructuring assignment foo unnecessarily renamed."]
},
{
code: "import {/* comment */foo as foo} from 'foo';",
output: "import {/* comment */foo} from 'foo';",
errors: ["Import foo unnecessarily renamed."]
},
{
code: "import {foo,/* comment */bar as bar} from 'foo';",
output: "import {foo,/* comment */bar} from 'foo';",
errors: ["Import bar unnecessarily renamed."]
},
{
code: "import {foo/**/ as foo} from 'foo';",
output: null,
errors: ["Import foo unnecessarily renamed."]
},
{
code: "import {foo /**/as foo} from 'foo';",
output: null,
errors: ["Import foo unnecessarily renamed."]
},
{
code: "import {foo //\nas foo} from 'foo';",
output: null,
errors: ["Import foo unnecessarily renamed."]
},
{
code: "import {foo as/**/foo} from 'foo';",
output: null,
errors: ["Import foo unnecessarily renamed."]
},
{
code: "import {foo as foo/* comment */} from 'foo';",
output: "import {foo/* comment */} from 'foo';",
errors: ["Import foo unnecessarily renamed."]
},
{
code: "import {foo as foo/* comment */,bar} from 'foo';",
output: "import {foo/* comment */,bar} from 'foo';",
errors: ["Import foo unnecessarily renamed."]
},
{
code: "let foo; export {/* comment */foo as foo};",
output: "let foo; export {/* comment */foo};",
errors: ["Export foo unnecessarily renamed."]
},
{
code: "let foo, bar; export {foo,/* comment */bar as bar};",
output: "let foo, bar; export {foo,/* comment */bar};",
errors: ["Export bar unnecessarily renamed."]
},
{
code: "let foo; export {foo/**/as foo};",
output: null,
errors: ["Export foo unnecessarily renamed."]
},
{
code: "let foo; export {foo as/**/ foo};",
output: null,
errors: ["Export foo unnecessarily renamed."]
},
{
code: "let foo; export {foo as /**/foo};",
output: null,
errors: ["Export foo unnecessarily renamed."]
},
{
code: "let foo; export {foo as//comment\n foo};",
output: null,
errors: ["Export foo unnecessarily renamed."]
},
{
code: "let foo; export {foo as foo/* comment*/};",
output: "let foo; export {foo/* comment*/};",
errors: ["Export foo unnecessarily renamed."]
},
{
code: "let foo, bar; export {foo as foo/* comment*/,bar};",
output: "let foo, bar; export {foo/* comment*/,bar};",
errors: ["Export foo unnecessarily renamed."]
},
{
code: "let foo, bar; export {foo as foo//comment\n,bar};",
output: "let foo, bar; export {foo//comment\n,bar};",
errors: ["Export foo unnecessarily renamed."]
}
]
});